Skip to content

[SDK] Allow manifest to be a json string #3479

Merged
dnechay merged 10 commits intodevelopfrom
feat/sdk/manifest-url
Aug 12, 2025
Merged

[SDK] Allow manifest to be a json string #3479
dnechay merged 10 commits intodevelopfrom
feat/sdk/manifest-url

Conversation

@flopez7
Copy link
Copy Markdown
Contributor

@flopez7 flopez7 commented Jul 24, 2025 •
edited by portuu3
Loading

Issue tracking

#3478

Context behind the change

Rename manifest_url to manifest and update related methods (Setup and getManifest) in SDK

How has this been tested?

  • Ran unit tests
  • Deployed one escrow and set it up using SDK

Release plan

Deploy new SDK version
Deploy new subgraph

Potential risks; What to monitor; Rollback plan

None

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 8:43am
human-dashboard-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 8:43am
staking-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 8:43am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2025 8:43am
faucet-server ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2025 8:43am

@flopez7 flopez7 self-assigned this Jul 24, 2025
@flopez7 flopez7 requested a review from portuu3 July 24, 2025 16:02
portuu3
portuu3 previously requested changes Jul 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@portuu3 portuu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename also subgraph entities

@vercel vercel bot temporarily deployed to Preview – staking-dashboard July 27, 2025 15:13 Inactive
@vercel vercel bot temporarily deployed to Preview – human-app July 27, 2025 15:13 Inactive
@vercel vercel bot temporarily deployed to Preview – human-dashboard-frontend July 27, 2025 15:13 Inactive
@flopez7 flopez7 requested a review from portuu3 July 27, 2025 15:16
dnechay
dnechay requested changes Aug 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifestUrl -> manifest and getManifestUrl -> getManifest changes are missing for RepO & dashboard server

Comment thread packages/sdk/python/human-protocol-sdk/human_protocol_sdk/escrow/escrow_utils.py Outdated
Comment thread packages/sdk/typescript/human-protocol-sdk/src/escrow.ts
Comment thread packages/sdk/typescript/human-protocol-sdk/src/escrow.ts Outdated
@vercel vercel bot temporarily deployed to Preview – human-dashboard-frontend August 4, 2025 08:21 Inactive
@vercel vercel bot temporarily deployed to Preview – staking-dashboard August 4, 2025 08:21 Inactive
@vercel vercel bot temporarily deployed to Preview – human-app August 4, 2025 08:21 Inactive
@flopez7 flopez7 requested a review from dnechay August 4, 2025 09:54
dnechay
dnechay reviewed Aug 4, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK changes lgtm, but we still need to apply them in Reputation Oracle and Dashboard Server

@vercel vercel bot temporarily deployed to Preview – staking-dashboard August 4, 2025 15:01 Inactive
@vercel vercel bot temporarily deployed to Preview – human-dashboard-frontend August 4, 2025 15:01 Inactive
@vercel vercel bot temporarily deployed to Preview – human-app August 4, 2025 15:01 Inactive
@flopez7 flopez7 requested a review from dnechay August 4, 2025 15:24
dnechay
dnechay reviewed Aug 4, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dnechay dnechay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another place that needs rename of manifestUrl to manifest: ref
UPD: above not actual, I just missed the pull

I would suggest to export IEscrow from sdk, so in test we can create a generator with proper typing that will help us easily find such places in the future (now TS can't detect invalid types due to any usage)

dnechay
dnechay previously approved these changes Aug 4, 2025
View reviewed changes
@flopez7
Copy link
Copy Markdown
Contributor Author

flopez7 commented Aug 4, 2025

There is another place that needs rename of manifestUrl to manifest: ref UPD: above not actual, I just missed the pull

I would suggest to export IEscrow from sdk, so in test we can create a generator with proper typing that will help us easily find such places in the future (now TS can't detect invalid types due to any usage)

IEscrow is already exported https://github.com/humanprotocol/human-protocol/blob/develop/packages/sdk/typescript/human-protocol-sdk/src/interfaces.ts

@dnechay
Copy link
Copy Markdown
Collaborator

dnechay commented Aug 5, 2025

@flopez7 nice! Seems like I missed that update. Will improve RepO tests after you merge this (to avoid conflicts)

@KirillKirill KirillKirill mentioned this pull request Aug 11, 2025
Merged
@dnechay
Copy link
Copy Markdown
Collaborator

dnechay commented Aug 12, 2025

@flopez7 is it finalized?

@flopez7
Copy link
Copy Markdown
Contributor Author

flopez7 commented Aug 12, 2025

@dnechay Yes, @portuu3 was deploying it in subgraph before merging it

@dnechay dnechay merged commit 7dd900d into develop Aug 12, 2025
14 checks passed
@dnechay dnechay deleted the feat/sdk/manifest-url branch August 12, 2025 14:10
@dnechay dnechay mentioned this pull request Aug 12, 2025
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnechay dnechay dnechay approved these changes

@portuu3 portuu3 Awaiting requested review from portuu3

Assignees

@flopez7 flopez7

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flopez7 @dnechay @portuu3